[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: RE: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access
> From: Michael S. Tsirkin <mst@redhat.com> > Sent: Thursday, July 6, 2023 12:51 PM > I don't see a statement that devices MAY support > VIRTIO_ADMIN_CMD_LEGACY_NOTIFY_QUERY > with entries returning just owner, just member, or both. > Ok. understood. From the driver notifications wording it didn't imply that it is related to VIRTIO_ADMIN_CMD_LEGACY_NOTIFY_QUERY. Will rewrite as above. > > Do you suggest to drop above statement? > > > > > > > > > + > > > > > +For the SR-IOV group type, the owner device supporting > > > > > +VIRTIO_ADMIN_CMD_LEGACY_COMMON_CFG_READ, > > > > > +VIRTIO_ADMIN_CMD_LEGACY_COMMON_CFG_WRITE, > > > > > +VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_READ, > > > > > +VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_WRITE and > > > > > +VIRTIO_ADMIN_CMD_LEGACY_NOTIFY_QUERY > > > > > +commands and its member device SHOULD follow the rules for the > > > > > +PCI Device ID, > > > > > > what does "its" mean here? Of the group? > > Yes, will change to the member device of the group. > > > > > Members of the SR-IOV group type are VFs. They can not follow the > > > rules for the Device ID: the spec says: > > > This field in all VFs returns FFFFh when read. > > > > > > Even if you somehow refer to the software it's extraneous anyway > > > since the spec proceeds: VI software should return the Vendor ID > > > value from the associated PF as the Vendor ID value for the VF. > > > > > > We'll need a separate statement for Device ID. > > > > > Will split the line for Device ID. > > > > > > > +Revision ID and Subsystem Device ID of the non-transitional > > > > > +devices documented in section \ref{sec:Virtio Transport Options > > > > > +/ Virtio Over PCI > > > Bus / PCI Device Discovery}.
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]