[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: RE: [PATCH 1/5] Add virtio Admin Virtqueue specification
> From: Michael S. Tsirkin <mst@redhat.com> > Sent: Tuesday, January 18, 2022 3:57 PM > > On Tue, Jan 18, 2022 at 08:23:57AM +0000, Parav Pandit wrote: > > > > > From: Michael S. Tsirkin <mst@redhat.com> > > > Sent: Tuesday, January 18, 2022 1:36 PM > > > > [..] > > > > > > > You can map it to a queue, yes. But something static and > > > > > > > read only such as list of commands maps well to config > > > > > > > space. And it's not controlling one device from another, so > > > > > > > does not really seem to belong in > > > > > the admin queue. > > > > > > > > > > > > > Aq serves the writing device config too in patch-5 in this patchset. > > > > > > > > > > List of available admin commands does not need to be written. > > > > > > > > > It is not written into the aq commands. > > > > It is part of the feature bit VIRTIO_F_ADMIN_PCI_VIRT_MANAGER > > > > indicating > > > a given functionality supported or not in patch-5. > > > > > > > > > Btw I don't see what does "VIRT_MANAGER" mean here. "manager" is > > > just a generic thing that means nothing, and VIRT just repeats VIRTIO. > > > > > VIRT doesn't repeat VIRTIO. > > It's literally a substring ;) > > > VIRT indicates PCI virtual functions. > > I'd use something like "SRIOV" then. Yeah. This is good short string. How about VIRTIO_F_ADMIN_PCI_SRIOV?
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]