[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [PATCH v3 2/3] transport-pci: Introduce legacy registers access commands
On Thu, Jun 08, 2023 at 06:55:29PM +0000, Parav Pandit wrote: > > > From: Michael S. Tsirkin <mst@redhat.com> > > Sent: Thursday, June 8, 2023 2:34 PM > > > > +0x0003 & VIRTIO_ADMIN_CMD_LCC_REG_READ & Read legacy common > > configuration registers of a member device \\ > > > +\hline > > > +0x0004 & VIRTIO_ADMIN_CMD_LD_REG_WRITE & Write legacy device > > registers of a member device \\ > > > +\hline > > > +0x0005 & VIRTIO_ADMIN_CMD_LD_REG_READ & Read legacy device > > registers of a member device \\ > > > +\hline > > > +0x0006 & VIRTIO_ADMIN_CMD_LQ_NOTIFY_QUERY & Read the queue > > > +notification offset for legacy interface \\ \hline > > > > Could you avoid such drastic abbreviation in command names? > > Standard things like CMD,CFG are ok, but LCC/LD will not ring any bells for > > anyone, except maybe confusingly make one think of "C Compiler" and "Link > > eDitor". > > Let's just LEGACY_COMMON_CFG/LEGACY_DEVICE_CFG? > > > It looked too long before abbreviating it. > Will change. > > VIRTIO_ADMIN_CMD_LEGACY_COMMON_REG_READ > VIRTIO_ADMIN_CMD_LEGACY_DEV_REG_READ I think you can drop _REG_ that does not really add any value and does not match anything in the spec. _CFG_ would make sense spec calls this common configuration and device configuration. -- MST
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]