On Sat, Nov 24, 2018 at 3:27 PM Robert van Engelen <engelen@genivia.com> wrote:
Hi Phil,Please fetch commitÂd899655Âwith the latest changes, see the diffs:Âhttps://github.com/oasis-tcs/xliff-omos-jliff/commit/d8996559a57c1f2b8c53af852d44a08d9bf13314#diff-b89ba9003dca25e3d00f69ed10fdb1bfÂThe BLUE part is what I changed in the schema to add the id property:  "locQualityIssues": {   "description": "A standoff wrapper element to group any number of single issue elements related to the same span of source or target content",   "type": "object",   "properties": {    "id": { "$ref": "#/definitions/NMTOKEN" },    "items": {     "type": "array",     "items": { "$ref": "#/definitions/locQualityIssue" },     "minItems": 1    }   },   "additionalProperties": false,   "required": [ "items" ]  },TheÂlocQualityIssueÂtype had its id property added some time ago, so I left it untouched.Thanks.- Robert Dr. Robert van Engelen, CEO/CTOÂGenivia Inc.On Nov 22, 2018, at 11:35 AM, Phil Ritchie <phil.ritchie@vistatec.com> wrote:
RobertÂThanks for the commit but despite your explanation below it looks like you have added the id property to the contained locQualityIssueâs instead of the wrapper.Â<image001.png>ÂPhilÂ
PhilÂRitchieâ
ChiefÂTechnologyÂOfficer Â|Â Vistatec
VistatecÂHouse,Â700ÂSouthÂCircularÂRoad,
Kilmainham,ÂDublinÂ8,ÂIreland.
Tel:Â +353Â1Â416Â8000 Â|Â Direct:Â +353Â1Â416Â8024
Email:Â phil.ritchie@vistatec.com
www.vistatec.com Â|Â ISOÂ9001 Â|Â ISOÂ13485 Â|Â ISOÂ17100 Â|Â ISOÂ27001 ThinkÂGlobal
Vistatec Ltd. Registered in Ireland 268483. Registered Office, Vistatec House, 700, South Circular Road, Kilmainham. Dublin 8. Ireland.
The information contained in this message, including any accompanying documents, is confidential and is intended only for the addressee(s).Â
âThe unauthorized use, disclosure, copying, or alteration of this message is strictly forbidden.Â
If you have received this message in error please notify the sender immediately.From:ÂRobert van Engelen <engelen@genivia.com>Â
Sent:ÂTuesday 13 November 2018 17:13
To:ÂPhil Ritchie <phil.ritchie@vistatec.com>
Cc:ÂXLIFF OMOS TC <xliff-omos@lists.oasis-open.org>
Subject:ÂRe: [xliff-omos] locQualityIssue idÂÂPhil et al.ÂThe JLIFF 2.1 schema in the GitHub repo is updated to include the id property on locQualityIssue.ÂQuoting David:ÂJLIFF the id should be on the wrapper arrayÂThis means we need an object that wraps the array. The object will contain the id property and an array property:  "its_locQualityIssues": {   "description": "A standoff wrapper element to group any number of single issue elements related to the same span of source or target content",   "type": "object",   "properties": {    "id": { "$ref": "#/definitions/NMTOKEN" },    "items": {     "type": "array",     "items": { "$ref": "#/definitions/its_locQualityIssue" },     "minItems": 1    }   },   "additionalProperties": false,   "required": [ "items" ]  },ÂThe property name for the the array âitemsâ is somewhat arbitrary. Any ideas for a better name?Â- Robert Dr. Robert van Engelen, CEO/CTOÂGenivia Inc.
 voice: (850) 270 6179 ext 104
 fax: (850) 270 6179
 mobile: (850) 264 2676ÂOn Nov 5, 2018, at 12:46 PM, Phil Ritchie <phil.ritchie@vistatec.com> wrote:Â
I think we need locQualityIssue to have an id property. Otherwise I see no way to reference an individual issue within an array of locQualityIssues when using standoff.Â
Kilmainham,ÂDublinÂ8,ÂIreland.
The information contained in this message, including any accompanying documents, is confidential and is intended only for the addressee(s).Â
âThe unauthorized use, disclosure, copying, or alteration of this message is strictly forbidden.Â
If you have received this message in error please notify the sender immediately.