< Home | Return to Ballot listing

Ballot Details    TC Member Ballot View
Ballot 02b: revised design changes + change drafts for issues #321 and #335

Provide mechanism for inlining externalized properties data into the root log and perform external property file related renames?

The design changes for issues #321 and #335 were previously approved, but adjustments were made afterward. Shall the adjustments be approved, and shall the resulting change draft be approved?

The change draft is referenced in this ballot.

The change draft is for the following two issues.

The provisional draft with the changes for all ballots merged is here:


Adjustments to issue #321:
Erratum: The name of the new property should be sarifLog.inlineExternalProperties, not inlineExternalPropertyFiles, and it is an array of externalProperties objects (as defined in §4.3 of the spec), not externalPropertyFile objects.

If you look at all the examples above, you'll see that they really are arrays of externalProperties objects. @kupsch's first example proposed to name the new property inlineExternalFiles, which would be ok. Later in the thread, I proposed inlineExternalProperties, as suggested here, which I prefer because it matches the name of the objects in the array.

"inlineExternalPropertyFiles", as we proposed in the ballot, is just wrong. There is an object in the spec called externalPropertyFile, but it is just a "locator" for an external file. Our new sarifLog property contains the contents of "external" files, not locators for them.


Adjustments to issue #335:
In the externalProperties object:
Rename the instanceGuid property to guid.
Rename the properties property to externalizedProperties.
Add a property named properties that is a property bag.
In the externalPropertyFile object:
Rename the object to externalPropertyFileReference.
Rename the instanceGuid property to guid.
Rename the artifactLocation property property to location.
With regard to the run.externalPropertyFiles property, and the object it contains:
Rename it to run.externalPropertyFileReferences.
Change the name of the contained object’s properties property to externalizedProperties.
Remove the run. prefix from the property names.

 [ ]  Yes
 [ ]  No
 [ ]  Abstain
Opening:   Friday, 15 March 2019 @ 10:00 pm PDT
Closing:   Friday, 22 March 2019 @ 10:00 pm PDT
Group:   OASIS Static Analysis Results Interchange Format (SARIF) TC
Ballot has closed.

Referenced Items
Name Type Date Action

Voting Details

Voting Summary

Options with highest number of votes are bold

Option # Votes % of Total
Yes 8 100%
No 0 0%
Abstain 0
Eligible members who have voted: 8 of 9 89%
Eligible members who have abstained: 0 of 9 0%
Eligible members who have not voted: 1 of 9 11%

Voting Details

Voter Company VoteReference Document and/or Comment
Paul Anderson
GrammaTech, Inc.
David Keaton
Henny Sipma
Kestrel Technology
Yekaterina O'Neil
Micro Focus
Chris Meyer
Michael Fanning
Laurence Golding
Jim Kupsch
Luke Cartey