Document:
03643: Resolve Issue #75: virtio-net: Speed and Duplex documentation mistakes

Draft (A preliminary unapproved sketch, outline, or version.)

Details

Submitted By Mr. Michael S. Tsirkin on 2021-09-07 9:10 pm UTC

Publication Type

None at this time.

Group / Folder

OASIS Virtual I/O Device (VIRTIO) TC / System Ballot Results

Modified by

Not modified.

Copy

This document is not a copy.

Technical Contact

None at this time.

Download Count

179

Download Agreement

None at this time.

Description

Please vote Yes if you agree with all of the following. If you disagree, please vote No. If you don't have an opinion, please vote Abstain. I move that: The TC agrees to resolve the following specification issue: Issue #75: virtio-net: Speed and Duplex documentation mistakes -------------------------------------- The spec says that the duplex field has the value 0x00 for full duplex and 0x01 for half duplex, however the current implementations in QEMU and the virtio Linux driver use the values the other way around. DUPLEX_FULL is defined as 1 and DUPLEX_HALF is defined as 0. These values are put into the field if the corresponding config value (duplex=full/half) is found. Also, when describing the possible values of the speed config field, the maximum value and the value for unknown speed are listed as "0x7ffffffff" and "0xfffffffff" respectively. They both have an extraneous "f" nibble, as they wouldn't fit into a 32-bit field this way. Proposal ("[PATCH] virtio-net: fix speed, duplex") can be found at: https://lists.oasis-open.org/archives/virtio-comment/202009/msg00000.html -------------------------------------- The TC accepts the following proposed changes to the specification: -------------------------------------- https://lists.oasis-open.org/archives/virtio-comment/202009/msg00000.html -------------------------------------- The TC agrees to include the above change(s) in specification version(s) "virtio-v1.2-cs01", and future versions of the specification. -------------------------------------- Reminder: A Voting Member must be active in a TC to maintain voting rights. As the Virtio TC has adopted a standing rule to conduct business only by electronic ballot, without Meetings, a Voting Member who fails to cast a ballot in two consecutive Work Product Ballots loses his or her voting rights at the close of the second ballot missed. --------------------------------------