Please vote Yes if you agree with all of the following.
If you disagree, please vote No.
If you don't have an opinion, please vote Abstain.
I move that:
The TC accepts the following changes to the specification:
****************************************************************************
* trivial corrections: These address all comments received on CSPRD05
****************************************************************************
------------------------------------------------------------------------
r554 | mstsirkin | 2016-02-16 19:09:07 +0200 (Tue, 16 Feb 2016) | 16 lines
virtio-net: fix inconsistent legacy header size
Current text says:
The legacy driver only presented num_buffers in the struct
virtio_net_hdr when VIRTIO_NET_F_MRG_RXBUF was not negotiated;
Should be:
"... was negotiated ..." instead of "... was not negotiated ..."
To be consistent with the following:
without that feature the structure was 2 bytes shorter.
Reported-by: Thomas Huth
Signed-off-by: Michael S. Tsirkin
Acked-by: Cornelia Huck
------------------------------------------------------------------------
r555 | mstsirkin | 2016-02-16 19:09:29 +0200 (Tue, 16 Feb 2016) | 9 lines
virtio header: tweak change motivation
The changes are not just to remove Linux assumptions,
we have also renamed ring->queue.
Tweak the header description accordingly.
Signed-off-by: Michael S. Tsirkin
Acked-by: Cornelia Huck
------------------------------------------------------------------------
r558 | mstsirkin | 2016-02-16 19:10:51 +0200 (Tue, 16 Feb 2016) | 9 lines
virtio-ring.h -> virtio-queue.h
Since vring* and VRING* have been replaced with virtq* and VIRTQ*
respectively, rename the header virtio_ring.h to virtio_queue.h.
Suggested-by: Kevin Lo
Signed-off-by: Michael S. Tsirkin
Acked-by: Cornelia Huck
------------------------------------------------------------------------
r559 | mstsirkin | 2016-02-16 19:11:14 +0200 (Tue, 16 Feb 2016) | 22 lines
init: sort status bits
Status bit order is inconsistent: they are neither in increasing
order nor in the order they are likely to be used.
The second approach seems more useful since there aren't
that many bits, so the numerical order does not help much.
A typical order of use would be:
ACKNOWLEDGE
DRIVER
then either FAILED or FEATURES_OK
then either FAILED or DRIVER_OK
then DEVICE_NEEDS_RESET (if device detects an error)
Sort the bits accordingly.
Reported-by: Kevin Lo
Signed-off-by: Michael S. Tsirkin
Acked-by: Cornelia Huck
------------------------------------------------------------------------
r567 | mstsirkin | 2016-02-16 21:32:32 +0200 (Tue, 16 Feb 2016) | 4 lines
acknowledgements: update affiliation for Thomas Huth
Signed-off-by: Michael S. Tsirkin
------------------------------------------------------------------------
r568 | mstsirkin | 2016-02-16 21:33:08 +0200 (Tue, 16 Feb 2016) | 5 lines
acknowledgements: acknowledge review by Kevin Lo
Cc: Kevin Lo
Signed-off-by: Michael S. Tsirkin
------------------------------------------------------------------------
r569 | mstsirkin | 2016-02-16 21:33:33 +0200 (Tue, 16 Feb 2016) | 8 lines
title: drop Rusty's email from chair/editor list
I kept Rusty's name in the acknowledgements section,
but listing him as Chair/Editor does not help since
the email listed bounces.
Signed-off-by: Michael S. Tsirkin
------------------------------------------------------------------------
****************************************************************************
* changelog updates:
****************************************************************************
------------------------------------------------------------------------
r565 | mstsirkin | 2016-02-16 19:31:33 +0200 (Tue, 16 Feb 2016) | 4 lines
cl: list changes since CSPRD05
Signed-off-by: Michael S. Tsirkin
********************************************************************
* changes related to change tracking (affecting diff output formatting only):
********************************************************************
------------------------------------------------------------------------
r556 | mstsirkin | 2016-02-16 19:09:52 +0200 (Tue, 16 Feb 2016) | 6 lines
headerfile: rename virtio_ring to virtio queue
Done as a separate commit for benefit of latexdiff.
Signed-off-by: Michael S. Tsirkin
------------------------------------------------------------------------
r557 | mstsirkin | 2016-02-16 19:10:13 +0200 (Tue, 16 Feb 2016) | 7 lines
Revert "headerfile rename virtio_ring to virtio queue"
This immediately reverts the previous commit, solely for the
benefit of latexdiff.
Signed-off-by: Michael S. Tsirkin
------------------------------------------------------------------------
r560 | mstsirkin | 2016-02-16 19:11:35 +0200 (Tue, 16 Feb 2016) | 6 lines
fixupdiff: update for latest perl
Escape {} in regexes to avoid warnings in latest perl.
Signed-off-by: Michael S. Tsirkin
------------------------------------------------------------------------
r561 | mstsirkin | 2016-02-16 19:11:57 +0200 (Tue, 16 Feb 2016) | 7 lines
virtio header: fix diff generation
add old cross reference as well as an chapter parameter
to avoid latexdiff errors when chapter is renamed.
Signed-off-by: Michael S. Tsirkin
------------------------------------------------------------------------
r562 | mstsirkin | 2016-02-16 19:12:18 +0200 (Tue, 16 Feb 2016) | 7 lines
fixupdiff: actually apply the DIFadd/DIFdel hack
looks like recent changes made it inactive: must
change $line, not $_.
Signed-off-by: Michael S. Tsirkin
------------------------------------------------------------------------
r563 | mstsirkin | 2016-02-16 19:12:41 +0200 (Tue, 16 Feb 2016) | 4 lines
makediff: cherry pick file name change
Signed-off-by: Michael S. Tsirkin
------------------------------------------------------------------------
r566 | mstsirkin | 2016-02-16 20:09:33 +0200 (Tue, 16 Feb 2016) | 7 lines
makediff: suppress diff for chater names
Temporary hack since we have nameref pointing
to a chapter name, and that conflicts with latexdiff.
Signed-off-by: Michael S. Tsirkin
------------------------------------------------------------------------
The TC agrees to include the above change(s) in virtio-v1.0-cs04 and future
versions of the specification.
The TC resolves that all comments received on CSPRD05 have been adequately addressed.
The TC resolves that the above changes to virtio-v1.0-csprd05 are all Non-Material.
The TC resolves to request a Special Majority Vote for the advancement of the draft
virtio-v1.0-wd04, with the above changes, as a Committee Specification virtio-v1.0-cs04.
Location of the specification draft with the above changes:
https://www.oasis-open.org/apps/org/workgroup/virtio/download.php/57548/virtio-v1.0-wd04.zip
This archive includes the editable Tex sources,
specification in PDF and HTML formats, as well as
versions with changes since CS03 highlighted.
You can also use the "revision history" chapter to locate the changes more easily:
revision numbers 554 to 559 inclusive in this chapter refer to changes made
since virtio-v1.0-csprd05, previous changes refer to changes made between
virtio-v1.0-cs03 and virtio-v1.0-csprd05. |
